Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "KEP-168-pending-workload-visibility" before deprecation. #3112

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #2256

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 23, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2024
Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 1b988df
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66f2d7821b129400084cdba0

@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo

@k8s-ci-robot k8s-ci-robot requested a review from mimowo September 23, 2024 08:33
@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-KEP-168-pending-workloads-visibility branch from a06eccc to 29d2f61 Compare September 23, 2024 08:41
@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-KEP-168-pending-workloads-visibility branch from 29d2f61 to 7dee103 Compare September 23, 2024 09:21
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2024
@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-KEP-168-pending-workloads-visibility branch from 7dee103 to 3194cfc Compare September 23, 2024 09:22
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 23, 2024
@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-KEP-168-pending-workloads-visibility branch from 3194cfc to 65f3571 Compare September 23, 2024 09:27
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2024
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Leaving approval to @tenzen-y

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 30bb951d6c4cbf1ae95a06c7de552fb5c989a5b9

@mbobrovskyi
Copy link
Contributor Author

/assign @tenzen-y

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2024
Co-authored-by: Michal Wozniak <michalwozniak@google.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@mbobrovskyi mbobrovskyi force-pushed the cleanup/update-KEP-168-pending-workloads-visibility branch from d34ba5a to 1b988df Compare September 24, 2024 15:15
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7f8307becc916669145d3acd40eb99adbdbc0852

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 650c749 into kubernetes-sigs:main Sep 24, 2024
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Sep 24, 2024
@mbobrovskyi mbobrovskyi deleted the cleanup/update-KEP-168-pending-workloads-visibility branch September 24, 2024 16:51
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
Co-authored-by: Michal Wozniak <michalwozniak@google.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants